Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PoA module support #1139

Closed
fmorency opened this issue May 21, 2024 · 2 comments
Closed

Add PoA module support #1139

fmorency opened this issue May 21, 2024 · 2 comments
Assignees

Comments

@fmorency
Copy link
Contributor

title

@Reecepbcups Reecepbcups self-assigned this May 22, 2024
@Reecepbcups
Copy link
Member

Reecepbcups commented May 22, 2024

ref: cleanup and prettify https://github.com/strangelove-ventures/poa/blob/main/e2e/helpers/poa.go (use gRPC for queries instead). See about any upstream repos using and grab helpers too, if any

cosmos/module_poa.go

also import it as a dep and default register interfaces. No downside since we depend on staking within POA anyways

@Reecepbcups
Copy link
Member

Reecepbcups commented Sep 16, 2024

For ICT, I am against adding support and adding in more upstream blockers for SDK upgrades.

The better approach here is to have the ICT helpers done in the POA module properly. This way you just import poa in your e2e/interchaintest directory and use it there.

This goes along with the refactor I want to build out in ICT to make extending it easier

Groups is still on the table since it is a core part of the SDK, just not a priority for us atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants