Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-a11y: added 'name' param for generate unique key for item #6118

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Addon-a11y: added 'name' param for generate unique key for item #6118

merged 1 commit into from
Mar 16, 2019

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Mar 15, 2019 •
edited
Loading

Issue: #6107

What I did

I added name prop Report component for pass to all child. React (and angular? and vue? and etc) in vdom elements list by key. Sometimes (read #6107) in any tabs has components with same key. It confuse react and he reuse state from other report component.

Im not sure that someone can understand my english, but im trying. :(

How to test

  • Is this testable with Jest or Chromatic screenshots?
    yes
  • Does this need a new example in the kitchen sink apps?
    no
  • Does this need an update to the documentation?
    no

@Armanio Armanio requested a review from jbovenschen as a code owner March 15, 2019 21:57
shilman
shilman approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@shilman shilman added cleanup Minor cleanup style change that won't show up in release changelog addon: a11y labels Mar 16, 2019
@shilman shilman added this to the 5.0.x milestone Mar 16, 2019
@shilman shilman added bug and removed cleanup Minor cleanup style change that won't show up in release changelog labels Mar 16, 2019
@shilman shilman merged commit 59582f5 into storybookjs:next Mar 16, 2019
@shilman shilman mentioned this pull request Mar 16, 2019
Closed
@Armanio Armanio deleted the fix/a11y_reports_key branch March 16, 2019 09:27
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@jbovenschen jbovenschen Awaiting requested review from jbovenschen

Assignees
No one assigned
Labels
addon: a11y bug
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Armanio @shilman