Update release process and master becomes the stable branch
#4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
alexandrebodin,
Hypnosphi and
ndelangen
as code owners
Hypnosphi
reviewed
Nov 5, 2018
|
Let's also update https://github.com/storybooks/storybook/blob/master/.github/PULL_REQUEST_TEMPLATE.md with a note that PR base shouldn't be changed from |
Codecov Report
@@ Coverage Diff @@
## master #4719 +/- ##
=======================================
Coverage 35.55% 35.55%
=======================================
Files 557 557
Lines 6738 6738
Branches 885 885
=======================================
Hits 2396 2396
Misses 3881 3881
Partials 461 461Continue to review full report at Codecov.
|
|
@Hypnosphi updated |
Hypnosphi
reviewed
Nov 5, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| If your answer is yes to any of these, please make sure to include it in your PR. | ||
|
|
||
| For maintainers only: Please tag your pull request with at least one of the following: | ||
| **For everybody:** Please submit all PRs to the `next` branch unless they are specific to current release. Storybook maintainers cherry-pick bug and documentation fixes into the `master` branch as part of the release process, so you shouldn't need to worry about this. |
There was a problem hiding this comment.
let's surround both notes with <!--/--> to hide them from actual PRs
There was a problem hiding this comment.
Hypnosphi
approved these changes
Nov 5, 2018
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Update
masterbranch per the release process v4 proposalHow to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]