-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Viewport - fix "defaultViewport" configuration #4683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4683 +/- ##
==========================================
- Coverage 35.59% 35.56% -0.03%
==========================================
Files 557 557
Lines 6732 6731 -1
Branches 884 885 +1
==========================================
- Hits 2396 2394 -2
- Misses 3876 3877 +1
Partials 460 460
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…port Addon Viewport - fix "defaultViewport" configuration
Issue: #4007
What I did
configureViewport
was failing if "viewports" field was not defineddefaultViewport
was not persistent with navigationP.S. Navigating between stories will always reset to the "defaultViewport" value, IMO it's a strange behavior when manually changing the viewport and navigating to a different story.
P.P.S the branch is called
addon-jest/fix-configureviewport
but I meantaddon-vieport/fix-configureviewport