-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start-storybook: Allow passing node flags #7923
Comments
@cookch10 What version of storybook are you using? |
@shilman , |
@cookch10 if you upgrade to v5 we've shortened the URL structure, which might be a workaround. i think yours is a reasonable feature request tho. |
Thanks @shilman , that's helpful, but doesn't solve the issue for me in all cases. Looking forward to this future enhancement! |
Automention: Hey @Keraito, you've been tagged! Can you give a hand here? |
@shilman |
Hello, I would like to work on this enhancement. Please let me know. |
I recommend importing |
Is your feature request related to a problem? Please describe.
When using react storybook with the knobs addon, some stories which have a large / complex props / json structure can cause the URL length to go beyond the maximum value defined by node, which causes the local dev server to respond with an error. The solution I have found is to pass the --max-http-header-size flag to node with an appropriate value, which mitigates this issue. Unfortunately it doesn't seem like calling start-storybook allows passing any parameters other than those for storybook.
For example, changing start-storybook.cmd to look like the following solves the issue:
Describe the solution you'd like
Would it be possible to update start-storybook to allow passing non-storybook parameters / flags?
Describe alternatives you've considered
I am welcome to any alternative approaches which could solve the issue.
Additional context:
I'm on Windows 7 x64 OS with Node v10.16.0 and npm v6.10.1
Resources:
nodejs/node#24692
https://github.com/nodejs/node/blob/master/src/node_options.h#L198
The text was updated successfully, but these errors were encountered: