Breaking changes in @storybook/polymer from 5.1.3 to 5.1.4 #7084
Labels
Comments
|
I'd have to look at a full reproduction of the issue, but this may be related to |
|
Can you try upgrading to 5.1.7? We've done a bunch of |
|
I'm getting these with 5.1.8 and with 5.2.0-alpha.26 Could be related. This is after patching diff --git a/node_modules/@open-wc/demoing-storybook/default-storybook-webpack-config.js b/node_modules/@open-wc/demoing-storybook/default-storybook-webpack-config.js
index ceef170..1c325d4 100644
--- a/node_modules/@open-wc/demoing-storybook/default-storybook-webpack-config.js
+++ b/node_modules/@open-wc/demoing-storybook/default-storybook-webpack-config.js
@@ -21,7 +21,7 @@ module.exports = ({ config, transpilePackages = ['lit-html', 'lit-element', '@op
'@babel/preset-env',
{
useBuiltIns: 'entry',
- corejs: '2',
+ corejs: '3',
},
],
],cc @daKmoR I have the sense this is not |
|
cc @ndelangen |
|
@bennypowers do you have a repo somewhere to take a look? Just to clarify, when you say you removed the dependencies on open-wc packages, do you mean you essentially replicated the entire |
Unfortunately nothing I can share at the moment.
Yes, specifically, reimplemented |
|
Same error after upgrading to 5.1.8 using React. I do not believe it's Polymer specific based on that (just wanted to clarify). This suddenly began to work after I updated my to be more specific to where my stories live |
|
Hi! Sorry if this is "too many cooks", but I am also having this issue with 5.1.8 and React. I get a ton of these errors while building webpack: If I downgrade to 5.1.3, things continue to work again. Happy to share more about my repo if asked! |
|
I did some repo spelunking today and noted the following, I hope it helps: and here are my dependencies: applying @jonkwheeler 's solution to the open-wc |
|
Errors persist with 5.1.9 |
|
I tried with last version 5.1.9 and I'm getting this errors: And where is the dependency versions: |
With that out of the way, I'm here to confirm that this issue is still relevant to 5.2.0-beta.7 |
|
@pksunkara we might need to give the |
|
Yeah, looks like it |
|
|
|
I was able to build storybook successfully with However, once the page loaded, I got these console errors: I get this in FF only, but in chromium (edgium) it works. I will file a separate issue. |
|
I was finally able to get 5.1.11 to build, using the following const and = require('crocks/logic/and');
const isString = require('crocks/predicates/isString');
const compose = require('crocks/helpers/compose');
const propOr = require('crocks/helpers/propOr');
const includes = x => xs => xs.includes(x);
const some = p => xs => xs.some(p);
const getUse = propOr(null, 'use');
const isStyleLoader = and(isString, includes('style-loader'));
const usesStyleLoader = compose(some(isStyleLoader), getUse);
const LIT_CSS_REGEXP = /src\/(.*)\.css$/
const options = require('../.babelrc');
const LIT_CSS_RULE = {
test: LIT_CSS_REGEXP,
loader: 'lit-css-loader',
}
const transpilePackages = [
'lit-html',
'lit-element',
'@open-wc',
'crocks'
]
// this is a separate config for only those packages
// the main storybook will use the .babelrc which is needed so storybook itself works in IE
const TRANSPILE_PACKAGES_RULE = {
test: /\.js$/,
include: transpilePackages.map(package => new RegExp(`node_modules(\\/|\\\\)(${package})(.*)\\.js$`)) ,
exclude: [/@babel\/runtime/, /core-js/, /axe-core/, /@storybook/],
loader: 'babel-loader',
options: {
plugins: [
'@babel/plugin-syntax-dynamic-import',
'@babel/plugin-proposal-object-rest-spread',
],
presets: [
[
'@babel/preset-env',
{
useBuiltIns: 'entry',
corejs: '3',
},
],
],
babelrc: false,
}
}
const BABEL_LOADER_RULE = {
test: /\.js$/,
loader: 'babel-loader',
exclude: [/@babel\/runtime/, /core-js/, /axe-core/],
options
}
module.exports = ({ config }) => {
config.module.rules = [
...config.module.rules,
BABEL_LOADER_RULE,
LIT_CSS_RULE,
TRANSPILE_PACKAGES_RULE,
];
config.module.rules
.find(usesStyleLoader)
.exclude = LIT_CSS_REGEXP;
return config;
}; |
|
If someone wants that commit be make it into @storybook/polymer, they'd have to open a PR here https://github.com/storybookjs/storybook/tree/master/app/polymer FYI we're dropping support for storybook for polymer and focussing on supporting plain web-components instead. |
|
We have dropped Polymer support. Therefore, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Upgrade @storybook/polymer from 5.1.3 to 5.1.4 breaks storybook.
and some 4 more similar errors.
To Reproduce
Steps to reproduce the behavior:
start-storybook -s .Expected behavior
Build the storybook project
Screenshots
If applicable, add screenshots to help explain your problem.
Code snippets
System:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: