Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook server will rebuild when a storyshots-puppeteer test case fail #7056

Closed
christopher-francisco opened this issue Jun 11, 2019 · 2 comments

Comments

@christopher-francisco
Copy link

christopher-francisco commented Jun 11, 2019

Describe the bug
When one of my storyshots-puppeteer test cases fail, the storybook server prints an extra

webpack building...
webpack built f26cd79228857e78fd4c in 510ms

I believe this might be just that the storybook server is watching for changes in all of the files, including the ones on __image_snapshots__/__diff_output__/. ?

As a result, my test suite isn't being ran successfully, it crashes with this OOM error. Maybe some kind of watch loop?

To Reproduce

  1. Have storyshots-puppeteer setup to work with a running storybook server (not static files)
  2. Make a test case fail on purpose
  3. Check your storybook server console

Expected behavior
Nothing should have happened, I didn't do any code changes

Possible workaround?
Is there any way of preventing a watch on this directory?

@christopher-francisco christopher-francisco changed the title Storybook server will rebuild whena storyshots-puppeteer test case fail Storybook server will rebuild when a storyshots-puppeteer test case fail Jun 11, 2019
@stale
Copy link

stale bot commented Jul 3, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 3, 2019
@stale
Copy link

stale bot commented Aug 2, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants