Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby + storybook + async/await + NODE_ENV=production == FAIL #6443

Closed
i8ramin opened this issue Apr 6, 2019 · 2 comments
Closed

Gatsby + storybook + async/await + NODE_ENV=production == FAIL #6443

i8ramin opened this issue Apr 6, 2019 · 2 comments

Comments

@i8ramin
Copy link

i8ramin commented Apr 6, 2019

Describe the bug

For some reason, the following combination of things causes the Gatsby build to fail:

  • async/await code
  • @storybook packages
  • NODE_ENV=production

Steps to reproduce

Repo with basic Gatsby setup + @storybook devDependencies + async/await code:
https://github.com/i8ramin/gatsby-test-prod-async

git clone https://github.com/i8ramin/gatsby-test-prod-async
cd gatsby-test-prod-async
NODE_ENV=production yarn install --ignore-optional
NODE_ENV=production yarn build

Possibly related GH issues

Expected behavior
Expect the site to build just fine. Which it does if you do any of the following:

  • remove the async/await code, it builds just fine.
  • remove the @storybook from devDependencies, it builds just fine.
  • add @storybook modules to dependencies, it builds just fine (after issuing rm -rf node_modules && NODE_ENV=production yarn install --ignore-optional)

Screenshots

Missing regenerator-runtime module in node_modules directory

Screen Shot 2019-04-06 at 10 04 36 AM

Code snippets
Full repo here https://github.com/i8ramin/gatsby-test-prod-async

System:

  • OS: MacOS (happens in Linux/Netlify as well)
  • Device: Macbook Pro
  • Browser: N/A
  • Framework: Gatsby
  • Version: 5.0.6

Additional context
Related issue created in Gatsby repo: gatsbyjs/gatsby#13176

@stale
Copy link

stale bot commented Apr 28, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 28, 2019
@stale
Copy link

stale bot commented May 28, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants