Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce portable stories support for Angular #28897

Open
Tracked by #29531 ...
yannbf opened this issue Aug 15, 2024 · 2 comments
Open
Tracked by #29531 ...

Introduce portable stories support for Angular #28897

yannbf opened this issue Aug 15, 2024 · 2 comments

Comments

@yannbf
Copy link
Member

yannbf commented Aug 15, 2024

When running portable stories tests with a setup file that does:

import { setProjectAnnotations } from "@storybook/angular"

setProjectAnnotations([])

the renderToCanvas annotation is used, which is the most important bit that provides PS support for a renderer.

This issue encompasses:

  • Checking how much effort it actually is to add PS support for Angular (with analogjs)
  • Updating the storybook add postinstall script to allow installation for this renderer
  • Updating docs
@jagipas
Copy link

jagipas commented Oct 24, 2024

Hello @yannbf ,

I hope you're doing well! I wanted to kindly ask if there are any updates or an estimated timeline for this issue. I saw that there is a related pull request (#28662), and I believe this would be a very interesting and useful feature to start using and testing.

Is there any additional information or progress regarding its review or merge?

Thank you so much for your time and all the hard work you put into this project!

@yannbf
Copy link
Member Author

yannbf commented Nov 4, 2024

Hey there @jagipas thanks for your words <3

Currently portable stories are already is possible with the https://github.com/storybookjs/testing-angular package which is community led so you can use it in your project!

Our current testing efforts are towards Vite based projects, so there is a chance it could "just work" with Angular projects using Vite, however that needs further testing and investment which we are not doing at this very moment, but have plans to do in a near future. So try @storybook/testing-angular out, keep feedback coming, and keep an eye out for Angular support in Storybook Test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants