Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable stories: Refactor Storybook preview and Portable stories to reuse logic [kasper] #28686

Closed
Tracked by #28388
yannbf opened this issue Jul 23, 2024 · 0 comments
Closed
Tracked by #28388
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented Jul 23, 2024

We mimic the run of the story in portable stories, but don’t reuse the same code for the story run. We should do that, see this TODO:

// TODO At some point this function should live in prepareStory and become the core of StoryRender.render as well.
// Will make a follow up PR for that
async function playStory<TRenderer extends Renderer>(
story: PreparedStory<TRenderer>,
context: StoryContext<TRenderer>
) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants