-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Custom favicon set up in manager-head.html does not show up in Firefox #21458
Comments
It seems that the favicon is shown by giving a value to the sizes attribute in Firefox. <link rel="shortcut icon" href="https://www.google.com/favicon.ico" sizes="192x192" /> Is this a specific issue with storybook? |
We can reproduce as well in Chrome. In Firefox, the bug only sometimes happens, but normally Firefox will take the icon specified in manager-head over the one defined by Storybook. The icons are specified in this order in the built index.html file: <!-- The icon defined by Storybook -->
<link rel="icon" type="image/svg+xml" href="./favicon.svg" />
<!-- Our icons defined in our manager-head.html -->
<link rel="icon" href="images/favicon-16.png" sizes="16x16">
<link rel="icon" href="images/favicon-32.png" sizes="32x32">
<link rel="icon" href="images/favicon-64.png" sizes="64x64">
<link rel="icon" href="images/favicon-192.png" sizes="192x192"> And due to undefined behaviour as to how browsers should work out which icon takes precedence, we're seeing different browsers choose different icons. |
With the latest version of Storybook (7.6.12), I've observed that In order to get a custom favicon working, I did the following:
|
Also have this issue, manager-head is being injected but storybook is injecting its own favion and cant override it |
I can't seem to override the default favicon in chrome as well. I'm using a
|
Describe the bug
Custom favicon set up in manager-head.html does not show up in Firefox
To Reproduce
The reporter used this repo: https://github.com/CivicDataLab/opub-mono
.storybook/manager-head.html
file and paste the following content to it:System
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: