Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-info] Why need break word for string prop ? #1860

Closed
DimaRGB opened this issue Sep 18, 2017 · 5 comments
Closed

[addon-info] Why need break word for string prop ? #1860

DimaRGB opened this issue Sep 18, 2017 · 5 comments

Comments

@DimaRGB
Copy link

DimaRGB commented Sep 18, 2017

Why need this wordBreak style for string prop ?
https://github.com/storybooks/storybook/blob/master/addons/info/src/components/PropVal.js#L28

it's ugly http://joxi.ru/V2V3w7EF0a8zMA

Thanks for cool addon.

@DimaRGB DimaRGB changed the title Why need break word for string prop ? [addon-info] Why need break word for string prop ? Sep 18, 2017
@danielduan
Copy link
Member

Is this a suggestion to remove the word break? It looks like if you have a really long word that gets displayed inside the prop table, it wouldn't break correctly. German words come to mind with something like this.

@DimaRGB
Copy link
Author

DimaRGB commented Sep 21, 2017

Ok, but why the description doesn't have?

@danielduan
Copy link
Member

Good question, I don't have an answer to that. If you'd like to open a PR to fix the prop table styles, please do! @DimaRGB

@stale
Copy link

stale bot commented Nov 14, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 14, 2017
@stale
Copy link

stale bot commented Nov 29, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants