Options set via addon should not override URL params

[Hypnosphi]

1. Run yarn start in repo root
2. Toggle actions panel with ⌘ ⇧ D
3. Reload the page

Expected: Actions panel stays hidden
Actual: It is hidden for a moment, and then shows up

[usulpro]

@Hypnosphi it happens because we use setOptions in config.js to setup initial state.
If you remove setOptions it'll behave as you describe

At least I don't think that it's a bug, or I missed something?

[Hypnosphi]

My point is that query params should have higher priority when present

[usulpro]

I see but setOptions can be used per story to setup appearance accordingly to selected story. It'll stop working if we change the priority

[Hypnosphi]

Well, if I reload the page, I stay on the same story. Links to other stories can be adjusted according to their specific setOptions

[usulpro]

So you offer to detect where it runs: inside a story or not? And depending on that change setOptions behavior?

[Hypnosphi]

I'd suggest roughly that:

1. explicit URL param has precedence when defining current view
2. hiding/showing a panel changes the current page URL
3. URL/action params in links to other stories are formed in this manner:
   a) If the story has set the corresponding option via local setOptions, use that
   b) Otherwise, use the current value

[Hypnosphi]

By the way, how do you use setOptions per story? Can't find that in docs

[usulpro]

this way:
https://github.com/storybooks/storybook/blob/master/examples/cra-kitchen-sink/src/stories/index.js#L83

or even like this:
https://github.com/storybooks/storybook/blob/master/examples/cra-kitchen-sink/src/stories/index.js#L70

so in this cases URL could be formed twice:

1. when you select a story in stories panel
2. when this story trigger setOptions and it updates query params

[Hypnosphi]

Oh, so it's inside story render. Ok, I think my suggestion may be restricted to setOptions in global setup. I think it would be enough to run initApi before handling routing (and setting only the explicitly present params in the latter)

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

[Hypnosphi]

I think it’s still an issue worth fixing

[Hypnosphi]

Will fix it as part of #2313