Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Sidebar search should not grab focus if input is selected #13943

Closed
shilman opened this issue Feb 17, 2021 · 1 comment
Closed

UI: Sidebar search should not grab focus if input is selected #13943

shilman opened this issue Feb 17, 2021 · 1 comment
Labels
bug good first issue ui: search ui

Comments

@shilman
Copy link
Member

shilman commented Feb 17, 2021 •
edited
Loading

Currently when I type a "?" (shift-/) in a text control, the search grabs focus which is weird/unexpected.

Video: https://www.loom.com/share/85c235336c514658805e4b5d1ff6ab93

Search should only grab focus if the current target is not an input element.

Introduced in #13884 cc @ghengeveld
This was referenced Feb 25, 2021
Closed
Merged
@shilman
Copy link
Member Author

shilman commented Feb 26, 2021

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-beta.4 containing PR #14062 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue ui: search ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shilman