Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check in package-lock.json #1346

Closed
tmeasday opened this issue Jun 23, 2017 · 1 comment
Closed

Check in package-lock.json #1346

tmeasday opened this issue Jun 23, 2017 · 1 comment
Labels
maintenance User-facing maintenance tasks

Comments

@tmeasday
Copy link
Member

As they were causing unexplained build failures, we decided to not check in package-lock.json files, but we should according to npm, AFAIK. We should figure out what's going on here.

See #1338
@tmeasday tmeasday added feature request maintenance User-facing maintenance tasks labels Jun 23, 2017
@tmeasday tmeasday mentioned this issue Jun 23, 2017
Closed
@danielduan
Copy link
Member

Think we've settled on using yarn so no npm lock files. #1703

@dependencies dependencies bot mentioned this issue Nov 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmeasday @shilman @danielduan