Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable Uglify. #1005

Closed
hearnden opened this issue May 9, 2017 · 11 comments
Closed

Add option to disable Uglify. #1005

hearnden opened this issue May 9, 2017 · 11 comments

Comments

@hearnden
Copy link

hearnden commented May 9, 2017

Uglify can't parse ES6 syntax, and the feature request to support ES6 syntax in Uglify is >3 years old (mishoo/UglifyJS#448). For projects that feed ES6 source into Storybook (e.g., as output from tsc targetting ES6), Uglify gets in the way.

A configuration option to disable Uglify in Storybook's webpack config was suggested here: #788 (comment), and would be a great help!

@ndelangen
Copy link
Member

ndelangen commented May 9, 2017

We can switch to babili plugin. I think that would solve both issues. If you feel like it, I will accept a PR.

Maybe we should pick a sane default and have people provide a custom webpack plugin if they want a more optimised or dev-friendly build.

@thuringia
Copy link

@ndelangen I created a PR for this, however, I did not create any configurability for the minifier.

@tesla3327
Copy link

I am running into this issue as well. Right now our workaround is to remove the UglifyJS plugin manually through "full-control" mode, which is a bit of an ugly hack.

Hopefully this can be merged soon?

@bigfish
Copy link

bigfish commented Jul 28, 2017

This will be in 3.2.0, right? Looking forward to that :)

@ndelangen
Copy link
Member

@bigfish this is not a change about the be released with 3.2.0, if you want to remove Uglify, you'll need to do so using webpack full control mode.

@bcomnes
Copy link

bcomnes commented Jul 28, 2017

+1000 on this. Would very much rather pass a single cli flag to turn things off than adopt full-control mode, especially since this arises out of a common babel usage incompatibility.

@stale
Copy link

stale bot commented Nov 14, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 14, 2017
@ndelangen
Copy link
Member

I will give this on my high priority list to work on after the 3.3 release.

Related:
#1570 (comment)

@stale stale bot removed the inactive label Nov 21, 2017
@stale
Copy link

stale bot commented Jan 5, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Jan 5, 2018
@bcomnes
Copy link

bcomnes commented Jan 5, 2018

Following up here, I dont recall the details, but updating some of our dependencies fixed the issues I was having that caused me to want to turn it off.

@stale stale bot removed the inactive label Jan 5, 2018
@Hypnosphi
Copy link
Member

We actually use ES6-aware uglify since #2530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants