From d87087897ccee697b2dbbd052527d884bf46bf09 Mon Sep 17 00:00:00 2001 From: jonniebigodes Date: Wed, 2 Feb 2022 18:38:45 +0000 Subject: [PATCH 1/3] Chore: (Docs) Updates link for support table With this small pull request, the Framework support link is updated to its proper location as the Addon Support table is no longer a source of truth. Addresses #17150 I'm aware that knobs is deprecated, but this prevents users from getting a 404 when clicking the link --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b5c2848..e25d46a 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ Storybook Addon Knobs allow you to edit props dynamically using the Storybook UI. You can also use Knobs as a dynamic variable inside stories in [Storybook](https://storybook.js.org). -[Framework Support](https://github.com/storybookjs/storybook/blob/master/ADDONS_SUPPORT.md). +[Framework Support](https://storybook.js.org/docs/react/api/frameworks-feature-support). This is what Knobs looks like: From 39adcfcc794398534806dd2b26b4551da237c693 Mon Sep 17 00:00:00 2001 From: Jeppe Reinhold Date: Sat, 1 Apr 2023 21:28:37 +0200 Subject: [PATCH 2/3] Upgrade Node in CI --- .github/workflows/release.yml | 4 ++-- .github/workflows/tests-unit.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index be895ed..95935a0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -12,10 +12,10 @@ jobs: - name: Prepare repository run: git fetch --unshallow --tags - - name: Use Node.js 14.x + - name: Use Node.js 16.x uses: actions/setup-node@v1 with: - node-version: 14.x + node-version: 16.x - name: Install dependencies uses: bahmutov/npm-install@v1 diff --git a/.github/workflows/tests-unit.yml b/.github/workflows/tests-unit.yml index b1173b6..3dbf3db 100644 --- a/.github/workflows/tests-unit.yml +++ b/.github/workflows/tests-unit.yml @@ -10,11 +10,11 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: "14.x" + node-version: "16.x" cache: yarn - name: install run: | yarn install --immutable - name: test run: | - yarn test --runInBand --ci \ No newline at end of file + yarn test --runInBand --ci From 0f1cfd9bc60fb5d91ab09e4bee98994a92cdf186 Mon Sep 17 00:00:00 2001 From: Jeppe Reinhold Date: Sat, 1 Apr 2023 21:28:52 +0200 Subject: [PATCH 3/3] Add note about pacakge version to README --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index e25d46a..e7e9b33 100644 --- a/README.md +++ b/README.md @@ -23,6 +23,8 @@ First of all, you need to install Knobs into your project as a dev dependency. yarn add @storybook/addon-knobs --dev ``` +The latest version of this addon supports Storybook v7. If you're using a previous version of Storybook you need to install the matching version of this addon, eg `@storybook/addon-knobs@6.4.0`. + within `.storybook/main.js`: ```js