-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the updated Figma embed #239
Comments
I ran into this today while using Firefox. According to this thread on the Figma Discord server,, it was an intentional change to url structure slated for April 1st. There's also a Figma community thread where someone reported the same kind of issue a few days ago, which leads me to believe something changed more recently than April 1st, or that the change is being progressively rolled out. Here's a snippet of the new url structure, which is covered in more detail in the Figma Embed docs :
|
Thanks for hopping on this. Unexpected change is always around the corner... |
Is there an estimation till this new link issue is solved? |
As workaround you can use the iframe embed url.
|
Affected design types
Describe the bug
I don't know if this is a very recent change or not. I've just now starting using the figma integration with storybook. I know figma has been going through lots of changes regarding developer mode, making it an additional cost and all... Maybe this is new URL is part of those recent changes.
Right-clicking on a figma variant, select
Copy as
>Copy link to selection
, it gives you a URL that starts withhttps://www.figma.com/design/...
Entering this into the figma or figspec parameters, the design panel then displays an error with the URL and
is not a valid Figma URL
It appears figma is still supporting the
file
path, it just forwards you to adesign
path in the end. So my workaround so far has been to use the Copy link to selection and simply swap outdesign
withfile
.Would be nice to update the regex figmaURLPattern in packages/storybook-addon-designs/src/manager/components/Figma.tsx to include
design
How to reproduce the bug?
Copy as
>Copy link to selection
. Note, the copied URL starts withhttps://www.figma.com/design/...
is not a valid Figma URL
Expected behaviour
Should display figma without an error for a valid url
Environment
Affected versions
8.0.1
Storybook versions
8.0.4
The text was updated successfully, but these errors were encountered: