From a31f6671b52d37b8493ca1690ca737ddd311558b Mon Sep 17 00:00:00 2001 From: Travis Vachon Date: Wed, 22 Nov 2023 03:37:54 -0800 Subject: [PATCH] fix: don't error when we can't figure out a name for a space (#1177) @juliangruber reported an issue with our documented space creation flow when the exported space access delegation doesn't specify a name and the client doesn't specify one manually: https://github.com/web3-storage/w3up/issues/1175 I think it's reasonable to require a name for spaces at some level, but I think the access-client API is too low-level for this. --- packages/access-client/src/agent.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/access-client/src/agent.js b/packages/access-client/src/agent.js index 22ff0fa23..d4d2d7c6d 100644 --- a/packages/access-client/src/agent.js +++ b/packages/access-client/src/agent.js @@ -346,12 +346,6 @@ export class Agent { ? Space.fromDelegation(delegation) : Space.fromDelegation(delegation).withName(name) - if (space.name === '') { - throw new Error( - 'Space has no name, please pass a `name` option to specify it' - ) - } - this.#data.spaces.set(space.did(), { ...space.meta, name: space.name }) await this.addProof(space.delegation)