Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Only deploy to prod/staging if all tests pass #106

Open
volmedo opened this issue Feb 3, 2025 · 0 comments
Open

[CI] Only deploy to prod/staging if all tests pass #106

volmedo opened this issue Feb 3, 2025 · 0 comments

Comments

@volmedo
Copy link
Member

volmedo commented Feb 3, 2025

Currently, the test jobs and the deploy run in parallel, so there is a possibility that we deploy buggy code. It shouldn't happen as the tests need to pass before a PR is merged (there is the option to bypass the checks, though) but it is good to make that dependency explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant