Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): locale for dates and tooltip for copy link button #492

Merged
merged 6 commits into from
Jun 10, 2024
Merged

feat(frontend): locale for dates and tooltip for copy link button #492

merged 6 commits into from
Jun 10, 2024

Conversation

66Leo66
Copy link
Contributor

@66Leo66 66Leo66 commented Jun 6, 2024

  • Globally configure moment.js locale and include corresponding locale resource, so dates formatted by moment.js will be localized. Works for upload form, upload complete dialog, manage uploads ...
  • Add a tooltip for copy link button in upload complete dialog. Reused i18n key from copy TOTP code. I would also suggest renaming that translation key as common or sth.

Comparison:

Before After
image image

@stonith404
Copy link
Owner

Great, thank you :) I've updated the translation key to common.button.clickToCopy but else it looks good to me.

@stonith404 stonith404 merged commit 1c7832a into stonith404:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonith404 stonith404 stonith404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@66Leo66 @stonith404