-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oauth): limited discord server sign-in #346
feat(oauth): limited discord server sign-in #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. I can't really test it as I don't have an own Discord server but if you've tested it properly we can merge it.
@stonith404 Can you build a dev image please? I will test it on my server tomorrow. |
@zz5840 Done 👍 |
@stonith404 I've tested it on my server, and it works as expected. Hope we can merge it. |
Sorry for the late response. Should I wait for your second PR before creating a new release? |
@stonith404 Either is fine, but it will take an extra week or two to complete that PR. If you want people to try this feature ASAP, it's better to create a new release. |
@zz5840 Great, I've created the release. Thank you for the contribution :) |
close #338