feat: change file for exists share #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll look into it at the weekend. |
stonith404
reviewed
Nov 3, 2023
stonith404
reviewed
Nov 3, 2023
stonith404
reviewed
Nov 3, 2023
stonith404
reviewed
Nov 3, 2023
stonith404
reviewed
Nov 3, 2023
stonith404
reviewed
Nov 3, 2023
stonith404
requested changes
Nov 3, 2023
|
Thank you for your suggestions. The points you mentioned are also areas where I am hesitant. I will revise them before submitting. In addition, I would like to know, from your perspective, after the user modifies the Share and clicks the save button, do you directly prompt the user with a toast or pop up the current modal box? And should I stay on the current page instead of jumping to the home page? |
|
@IvanLi-CN, for me, it doesn't really matter. Do what you think is best. If you ask for my opinion, I would suggest redirecting back to the "My Shares" page, as that is the page the user is coming from. |
IvanLi-CN
force-pushed
the
feat/add-remove-file-for-exists-share
branch
from
fd04aff to
a7c4a09
Compare
|
Modified, please check 😋 @stonith404 |
stonith404
approved these changes
Nov 4, 2023
Do it! 😋 |
|
Wow nice changes, good job ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #154 .
This is the effect achieved. Is there anything that needs to be adjusted in the process?
output_hevc.mp4