Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not white-on-black "可" symbol #46

Closed
parfait8566 opened this issue Jan 7, 2024 · 2 comments
Closed

Not white-on-black "可" symbol #46

parfait8566 opened this issue Jan 7, 2024 · 2 comments

Comments

@parfait8566
Copy link

Old table:
image

New table:
image

Also, it looks quite a bit weird on Anki. I guess it's harder to make it look right without svg files.

@parfait8566
Copy link
Author

Another thing: wouldn't it better to invert the position of forms and readings in the tables?

@stephenmk
Copy link
Owner

stephenmk commented Jan 7, 2024

I thought about using the color variables exposed by Yomitan's stylesheets to change the colors of that symbol when the user switches between light and dark themes. I didn't get around to trying it and I figured it was good enough as it was, but I agree it looked better before.

I just reuploaded a new version of Jitendex 4.0 for Yomitan which updates the colors on that symbol. Apologies to everyone who already downloaded and installed it.

The Yomitan color variables aren't exported to Anki, so you'll have to set the color variables on your Anki cards if you want the inverted effect. Otherwise it will still look like your second screenshot.

.card {
    --text-color: black; 
    --background-color: white;
}
.card.nightMode {
    --text-color: white; 
    --background-color: black;
}

wouldn't it better to invert the position of forms and readings in the tables?

Definitely not. The column width would be much wider and more variable on average. Horizontal space is at a premium in the popup window compared to vertical space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants