Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative gallery viewer #784

Closed
jerivas opened this issue Oct 1, 2013 · 7 comments
Closed

Alternative gallery viewer #784

jerivas opened this issue Oct 1, 2013 · 7 comments

Comments

@jerivas
Copy link
Collaborator

jerivas commented Oct 1, 2013

Hey Stephen, now that I'm working in the migration to Bootstrap 3 I came across the gallery again and I wanted to see if you had changed your mind on this issue. The solution I would like to propose this time is Magnific Popup. You can see it in action in a Mezzanine project in this theme over at MEZZaTHEME.

From the site: "Magnific Popup is a responsive jQuery lightbox plugin that is focused on performance and providing best experience for user with any device". I found the minimal approach very compatible with Mezzanine, and with the build tool we could create a bare-bones version tailored exclusively for serving images in the gallery. Alternatively we could use the inline and ajax capabilities to serve the forms for inline edition too.

Some of the advantages over the current implementation are responsiveness, capabilities to serve not only images (optional) and that it requires less markup, making the gallery template more semantic.

@stephenmcd
Copy link
Owner

Hey Ed, it sounds like a good idea.

Would you like to make it happen?

Thanks a lot for your help.

@jerivas
Copy link
Collaborator Author

jerivas commented Oct 2, 2013

Sure thing, Steve! Should I convert only the gallery viewer or dive into inline edition too?

@stephenmcd
Copy link
Owner

Maybe just start with the gallery to make things easy.

@jerivas
Copy link
Collaborator Author

jerivas commented Oct 2, 2013

Ok then, I'll bundle it in the other issue.

@jerivas
Copy link
Collaborator Author

jerivas commented Oct 4, 2013

This feature is now part of the bootstrap3 branch. Yay!

@stephenmcd
Copy link
Owner

Ok to close this issue then?

@jerivas
Copy link
Collaborator Author

jerivas commented Oct 7, 2013

Yep. If any bugs appear let's track them over #777

@jerivas jerivas closed this as completed Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants