Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom scope annotations are not processed by the compiler #118

Closed
stephanenicolas opened this issue Jul 6, 2016 · 2 comments
Closed

Custom scope annotations are not processed by the compiler #118

stephanenicolas opened this issue Jul 6, 2016 · 2 comments
Labels
enhancement has PR
Milestone
1.0.0

Comments

@stephanenicolas
Copy link
Owner

Singleton is processed and we create relaxed factories in case it is annotating a class.

But it's not the case for custom scope annotations (like context singleton). I don't think we can actually do that without saying that the annotation processor should intercept every annotation, which is considered a bad practice. Maybe we can have a look at Dagger 2 and see how they deal with this as they also have custom scopes working well.
@stephanenicolas
Copy link
Owner Author

we could provide an annotation processor parameter for this.. maybe. Not sure it works.

@stephanenicolas stephanenicolas mentioned this issue Aug 4, 2016
Closed
@stephanenicolas stephanenicolas added this to the 1.0.0 milestone Sep 29, 2016
@stephanenicolas stephanenicolas mentioned this issue Oct 1, 2016
Merged
@stephanenicolas
Copy link
Owner Author

This is shipped in 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement has PR
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@stephanenicolas