Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script does not honor RUSTC_WRAPPER #735

Closed
RalfJung opened this issue Aug 28, 2024 · 0 comments · Fixed by #737
Closed

Build script does not honor RUSTC_WRAPPER #735

RalfJung opened this issue Aug 28, 2024 · 0 comments · Fixed by #737

Comments

@RalfJung
Copy link
Contributor

This is the same issue as djc/rustc-version-rs#45 and rust-lang/libc#3772: the build script invokes rustc without properly applying the RUSTC_WRAPPER environment variable. That's a bug, it means tools that set RUSTC_WRAPPER to redirect rustc invocations somewhere else will not work properly. One such tool is rustc bootstrap; this issue blocks rust-lang/rust#127682.

(It also seems like this crate automatically enables nightly features when built on a nightly compiler. That's a bad idea, see rust-lang/rust#120804, rust-lang/rust#124339, SergioBenitez/version_check#23.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant