Skip to content

Commit 28ea21a

Browse files
authoredMar 22, 2020
Fix kernel panic for irq after fast-reboot (sonic-net#823)
After the change in master branch updating SAI from 3.5.3.1m-25 to 3.7.3.2, we always found kernel panic after running fast-reboot command in testing SONiC with traffic. In the up path of fast-reboot, we can find warning messages like "unhandled irq 16 error" before kernel panic, which implies that some components are not properly closed in the down path. This fix will unload certain kernel modules by stopping opennsl before fast-reboot, which is suggested by BRCM. Note that another part of the fix is to add 'ExecStop=-/etc/init.d/opennsl-modules stop' to sonic-buildimage:platform/broadcom/saibcm-modules/systemd/opennsl-modules.service, which will be included in another pull request.
1 parent 727b499 commit 28ea21a

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed
 

‎scripts/fast-reboot

+7
Original file line numberDiff line numberDiff line change
@@ -529,6 +529,13 @@ then
529529
systemctl stop nps-modules-`uname -r`.service || debug "Ignore stopping nps service error $?"
530530
fi
531531
532+
# Stop opennsl modules for Broadcom platform
533+
if [[ "$sonic_asic_type" = 'broadcom' ]];
534+
then
535+
service_name=$(systemctl list-units --plain --no-pager --no-legend --type=service | grep opennsl | cut -f 1 -d' ')
536+
systemctl stop "$service_name"
537+
fi
538+
532539
# Update the reboot cause file to reflect that user issued this script
533540
# Upon next boot, the contents of this file will be used to determine the
534541
# cause of the previous reboot

0 commit comments

Comments
 (0)