feat: ✨ add include_podiatrist_services() with tests
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is used to convert variables like `honuge` in the format `yyww` to dates in the format `YYYY-MM-DD`.
The podiatrist services logic is needed for `include_podiatrist_services()`.
signekb
commented
Dec 20, 2024
signekb
commented
Dec 20, 2024
R/yyww-to-date.R
Outdated
There was a problem hiding this comment.
This whole thing feels a bit hacky. Let me know if this isn't clear or you have another idea of how to do this.
This ensures that numeric input is converted to zero-padded characters of length 4
signekb
commented
Dec 22, 2024
signekb
commented
Dec 22, 2024
Comment on lines
+37
to
+39
| dplyr::full_join(column_names_to_lower(sssy), | ||
| by = dplyr::join_by(pnr, barnmak, speciale, honuge) | ||
| ) |> |
There was a problem hiding this comment.
After explicitly adding the columns to join by, I get a note from devtools::check():
I'm not sure how to fix this, since join_by() doesn't seem to allow the use of .data$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
algorithm.csvinclude_podiatrsit_services()functionhonugevariable to a date (yyww_to_yyyymmdd()) + tests for this functionlubridatepackage to our dependencies (needed for handling the date conversion)I also reran the pipeline to include the podiatrist services logic.
Closes #90
Checklist
just run-all(did not run this)