Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stencil flags aren't working to build Stencil apps/components for Internet Explorer (IE) #2894

Closed
davidprae opened this issue Apr 27, 2021 · 5 comments

Comments

@davidprae
Copy link

Stencil version:

@stencil/core@2.5.2

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
Viewing Stencil App in Internet Explorer always results in "This Stencil app is disabled for this browser". Running the build with --prod and/or --es5 produces the same result.

Expected behavior:
I can view the Stencil App in Internet Explorer.

Steps to reproduce:
Follow the docs for starting a new app (npm init stencil) and then either npm run build or npm run start with any combination of --prod --es5 and --dev always gives the same result.

Related code:
Just the base starter code, no mods.

Other information:
I came to the try just running the base starter app in IE because my Stencil components created with npm init stencil and choosing component don't work in IE either, presumably for the same reason (the flags don't actually do anything). Also note that running this script "start": "stencil build --dev --serve" (without --watch) does not actually start a server. I can create another ticket for this but I figured I'd mention it here since it help point towards a problem with the flags in general.

@ionitron-bot ionitron-bot bot added the triage label Apr 27, 2021
@johnjenkins
Copy link
Contributor

Hi!
Did you include the required polyfills?
https://stenciljs.com/docs/config-extras

@davidprae
Copy link
Author

Hey!
I wasn't aware of that extras property but I just tried it out and it worked! 🙌

Maybe this helper screen should be updated. The Please see the example below or our config docs... makes it sound like all you need are the flags:

Screen Shot 2021-04-28 at 8 54 21 AM

Thanks a ton!

@johnjenkins
Copy link
Contributor

yeah, agree. Those extras used to be bundled with an opt-out clause. Now they're opt-in. That page probably needs an update

@rwaskiewicz rwaskiewicz self-assigned this Jul 23, 2021
@ionitron-bot ionitron-bot bot removed the triage label Oct 11, 2021
@splitinfinities splitinfinities added Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through. triage labels Oct 11, 2021
@ionitron-bot ionitron-bot bot removed the triage label Oct 11, 2021
@splitinfinities
Copy link
Contributor

We updated this language as of v2.8.0! Thank you for calling this out!

@splitinfinities splitinfinities removed the Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through. label Oct 22, 2021
@splitinfinities
Copy link
Contributor

#2993 for reference!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants