-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot upgrade Puppeteer to v6 due to typings mismatch #2834
Comments
Just wanna confirm that this issue really exists 😞 |
+1 |
Just wanna confirm that this issue really exists disappointed |
Hey folks 👋 I'm going to close this issue, as this should be fixed in v2.7.0+ of Stencil. As of v2.7.0, you should be able to install Puppeteer v10. If you're able to, I would recommend updating to the latest version, which at the time of this writing is v2.9.0. If not, I understand, and would recommend using at least v2.7.1, which had a few bug fixes from the v2.7.0 release addressed in it. If your issue is not fully addressed in v2.7.0, please feel free to open another ticket! |
Stencil version:
I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/
Current behavior:
cannot compile/run stencil when puppeteer >= v6 is installed.
Expected behavior:
it should compile and run properly
Steps to reproduce:
$npm i puppeteer
Related code:
https://pptr.dev/#?product=Puppeteer&version=v6.0.0&show=api-release-notes
The newly provided typings do not match the legacy
@types/puppeteer
and the upgrade from puppeteer v5 to v6 is not possible...Other information:
upgrading the puppeteer dependency to >=6 and refactoring the types used, will fix the issue
https://github.com/ionic-team/stencil/blob/v2.4.0/package.json#L110
The text was updated successfully, but these errors were encountered: