Skip to content

Commit cb8df56

Browse files
fix(lazy): adjust the type of defineCustomElements
This fixes an issue with the type for `defineCustomElements` that we set in output-lazy-loader.ts. In #4419 we changed the return type of the function to be `void` (at runtime) but we didn't make a corresponding adjustment to the type declaration for the function that we generate here: https://github.com/ionic-team/stencil/blob/7d5dc6cf5e0d2020c513cc87b6b2e5b93eece9bc/src/compiler/output-targets/output-lazy-loader.ts#L88 This change adjusts that type declaration to have a `void` return value, instead of `Promise<void>`. See #4589 for more context
1 parent 7d5dc6c commit cb8df56

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/compiler/output-targets/output-lazy-loader.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export interface CustomElementsDefineOptions {
8585
ael?: (el: EventTarget, eventName: string, listener: EventListenerOrEventListenerObject, options: boolean | AddEventListenerOptions) => void;
8686
rel?: (el: EventTarget, eventName: string, listener: EventListenerOrEventListenerObject, options: boolean | AddEventListenerOptions) => void;
8787
}
88-
export declare function defineCustomElements(win?: Window, opts?: CustomElementsDefineOptions): Promise<void>;
88+
export declare function defineCustomElements(win?: Window, opts?: CustomElementsDefineOptions): void;
8989
export declare function applyPolyfills(): Promise<void>;
9090
9191
/**

0 commit comments

Comments
 (0)