refactor(compiler): remove legacy compiler

Author: adamdbradley

.prettierrc.json

@@ -0,0 +1,13 @@
+{
+  "arrowParens": "avoid",
+  "bracketSpacing": true,
+  "jsxBracketSameLine": false,
+  "jsxSingleQuote": false,
+  "quoteProps": "consistent",
+  "printWidth": 180,
+  "semi": true,
+  "singleQuote": true,
+  "tabWidth": 2,
+  "trailingComma": "all",
+  "useTabs": false
+}

.vscode/launch.json

@@ -41,21 +41,6 @@
       "internalConsoleOptions": "neverOpen",
       "disableOptimisticBPs": true
     },
-    {
-      "type": "node",
-      "request": "launch",
-      "name": "Style Modes",
-      "args": [
-        "${workspaceFolder}/bin/stencil",
-        "build",
-        "--dev",
-        "--next",
-        "--max-workers=0",
-        "--config",
-        "${workspaceFolder}/test/style-modes/stencil.config.ts"
-      ],
-      "protocol": "inspector"
-    },
     {
       "type": "node",
       "request": "launch",
@@ -72,38 +57,6 @@
       ],
       "protocol": "inspector"
     },
-    {
-      "type": "node",
-      "request": "launch",
-      "name": "Hello World NEXT",
-      "args": [
-        "${workspaceFolder}/bin/stencil",
-        "build",
-        "--next",
-        "--dev",
-        "--watch",
-        "--serve",
-        "--max-workers=0",
-        "--config",
-        "${workspaceFolder}/test/hello-world/stencil.config.ts"
-      ],
-      "protocol": "inspector"
-    },
-    {
-      "type": "node",
-      "request": "launch",
-      "name": "Hello World Prerender NEXT",
-      "args": [
-        "${workspaceFolder}/bin/stencil",
-        "build",
-        "--next",
-        "--prerender",
-        "--max-workers=0",
-        "--config",
-        "${workspaceFolder}/test/hello-world/stencil.config.ts"
-      ],
-      "protocol": "inspector"
-    },
     {
       "type": "node",
       "request": "launch",
@@ -116,12 +69,11 @@
     {
       "type": "node",
       "request": "launch",
-      "name": "Hello VDom NEXT",
+      "name": "Hello VDom",
       "args": [
         "${workspaceFolder}/bin/stencil",
         "build",
         "--watch",
-        "--next",
         "--debug",
         "--dev",
         "--config",
@@ -147,11 +99,10 @@
     {
       "type": "node",
       "request": "launch",
-      "name": "Ionic App NEXT",
+      "name": "Ionic App",
       "args": [
         "${workspaceFolder}/bin/stencil",
         "build",
-        "--next",
         "--dev",
         "--max-workers=0",
         "--config",
@@ -166,7 +117,6 @@
       "args": [
         "${workspaceFolder}/bin/stencil",
         "build",
-        "--next",
         "--dev",
         "--prerender",
         "--max-workers=0",
@@ -182,8 +132,7 @@
       "args": [
         "${workspaceFolder}/bin/stencil",
         "build",
-        "--dev",
-        "--next",
+        // "--dev",
         "--max-workers=0",
         "--config",
         "${workspaceFolder}/test/end-to-end/stencil.config.ts"
@@ -219,11 +168,10 @@
     {
       "type": "node",
       "request": "launch",
-      "name": "Todo App NEXT",
+      "name": "Todo App",
       "args": [
         "${workspaceFolder}/bin/stencil",
         "build",
-        "--next",
         "--dev",
         "--watch",
         "--serve",
@@ -253,26 +201,10 @@
       "type": "node",
       "request": "launch",
       "name": "Stencil Site Prerender",
-      "args": [
-        "${workspaceFolder}/bin/stencil",
-        "build",
-        "--prerender",
-        "--max-workers=1",
-        "--debug",
-        "--config",
-        "${workspaceFolder}/../stencil-site/stencil.config.ts"
-      ],
-      "protocol": "inspector"
-    },
-    {
-      "type": "node",
-      "request": "launch",
-      "name": "Stencil Site Prerender NEXT",
       "args": [
         "${workspaceFolder}/bin/stencil",
         "build",
         "--max-workers=0",
-        "--next",
         "--debug",
         "--config",
         "${workspaceFolder}/../stencil-site/stencil.config.ts"
@@ -303,7 +235,6 @@
         "build",
         "--max-workers=0",
         "--dev",
-        "--next",
         "--config",
         "${workspaceFolder}/test/karma/stencil.config.ts"
       ],
@@ -317,22 +248,6 @@
         "${workspaceFolder}/test/karma/test-prerender/prerender.js"
       ],
       "protocol": "inspector"
-    },
-    {
-      "type": "node",
-      "request": "launch",
-      "name": "Karma NEXT",
-      "args": [
-        "${workspaceFolder}/bin/stencil",
-        "build",
-        "--next",
-        "--max-workers=0",
-        "--watch",
-        "--dev",
-        "--config",
-        "${workspaceFolder}/test/karma/stencil.config.ts"
-      ],
-      "protocol": "inspector"
     }
   ]
 }

bin/stencil

@@ -14,22 +14,13 @@ try {
   }
 } catch (e) {}
 
-if (process.argv.indexOf('--legacy') === -1) {
-  if (process.argv.indexOf('--next') > -1) {
-    console.warn('\nThe next compiler is now the default and the --next flag is no longer needed.\n');
-  }
-  var cli = require('../cli/index.js');
-  cli.run({
-    process: process,
-    logger: cli.createNodeLogger(process),
-    sys: cli.createNodeSystem(process)
-  });
-
-} else {
-  var cliLegacy = require('../cli/index_legacy.js');
-  var nodeLegacy = require('../sys/node/index.js');
-  var sysLegacy = new nodeLegacy.NodeSystem();
-  var loggerLegacy = new nodeLegacy.NodeLogger();
-
-  cliLegacy.run(process, sysLegacy, loggerLegacy);
+if (process.argv.indexOf('--next') > -1) {
+  console.warn('\nThe next compiler is now the default and the --next flag is no longer needed.\n');
 }
+
+var cli = require('../cli/index.js');
+cli.run({
+  process: process,
+  logger: cli.createNodeLogger(process),
+  sys: cli.createNodeSystem(process)
+});

jest.config.js

@@ -5,7 +5,8 @@ module.exports = {
     "@app-globals": "<rootDir>/internal/app-globals/index.js",
     "@platform": "<rootDir>/internal/testing/index.js",
     "@runtime": "<rootDir>/internal/testing/index.js",
-    "@stencil/core/compiler": "<rootDir>/compiler/index.js",
+    "@stencil/core/cli": "<rootDir>/cli/index.js",
+    "@stencil/core/compiler": "<rootDir>/compiler/stencil.js",
     "@stencil/core/mock-doc": "<rootDir>/mock-doc/index.js",
     "@stencil/core/testing": "<rootDir>/testing/index.js",
     "@utils": "<rootDir>/src/utils"

package-lock.json

@@ -35,6 +35,7 @@
     "rollup.prod.ci": "rollup --config --config-prod --config-ci",
     "rollup.watch": "rollup --watch --config",
     "license": "node scripts --license",
+    "prettier": "prettier --write \"./src/**/*.{ts,tsx}\"",
     "test": "jest",
     "test.analysis": "cd test && npm run build",
     "test.dist": "node scripts --validate-build",
@@ -111,6 +112,7 @@
     "path-browserify": "^1.0.0",
     "pixelmatch": "4.0.2",
     "postcss": "^7.0.27",
+    "prettier": "^1.19.1",
     "prompts": "2.3.1",
     "puppeteer": "~2.1.1",
     "rollup": "1.32.0",

package.json

@@ -1,8 +1,6 @@
 import { BuildOptions } from './utils/options';
 import { cli } from './bundles/cli';
-import { cli_legacy } from './bundles/cli_legacy';
 import { compiler } from './bundles/compiler';
-import { compiler_legacy } from './bundles/compiler_legacy';
 import { createLicense } from './license';
 import { devServer } from './bundles/dev-server';
 import { emptyDir } from 'fs-extra';
@@ -11,12 +9,10 @@ import { mockDoc } from './bundles/mock-doc';
 import { release } from './release';
 import { screenshot } from './bundles/screenshot';
 import { sysNode } from './bundles/sys-node';
-import { sysNode_legacy } from './bundles/sys-node_legacy';
 import { testing } from './bundles/testing';
 import { validateBuild } from './test/validate-build';
 import { RollupOptions, rollup } from 'rollup';
 
-
 export async function run(rootDir: string, args: string[]) {
   try {
     if (args.includes('--release')) {
@@ -30,16 +26,13 @@ export async function run(rootDir: string, args: string[]) {
     if (args.includes('--validate-build')) {
       validateBuild(rootDir);
     }
-
   } catch (e) {
     console.error(e);
     process.exit(1);
   }
 }
 
-
 export async function createBuild(opts: BuildOptions) {
-
   await Promise.all([
     emptyDir(opts.output.cliDir),
     emptyDir(opts.output.compilerDir),
@@ -53,15 +46,13 @@ export async function createBuild(opts: BuildOptions) {
   await sysNode(opts);
 
   const bundles = await Promise.all([
+    //
     cli(opts),
-    cli_legacy(opts),
     compiler(opts),
-    compiler_legacy(opts),
     devServer(opts),
     internal(opts),
     mockDoc(opts),
     screenshot(opts),
-    sysNode_legacy(opts),
     testing(opts),
   ]);
 
@@ -71,22 +62,24 @@ export async function createBuild(opts: BuildOptions) {
   }, [] as RollupOptions[]);
 }
 
-
 export async function bundleBuild(opts: BuildOptions) {
   const bundles = await createBuild(opts);
 
-  await Promise.all(bundles.map(async rollupOption => {
-
-    rollupOption.onwarn = () => {};
-
-    const bundle = await rollup(rollupOption);
-
-    if (Array.isArray(rollupOption.output)) {
-      await Promise.all(rollupOption.output.map(async output => {
-        await bundle.write(output);
-      }));
-    } else {
-      await bundle.write(rollupOption.output);
-    }
-  }));
+  await Promise.all(
+    bundles.map(async rollupOption => {
+      rollupOption.onwarn = () => {};
+
+      const bundle = await rollup(rollupOption);
+
+      if (Array.isArray(rollupOption.output)) {
+        await Promise.all(
+          rollupOption.output.map(async output => {
+            await bundle.write(output);
+          }),
+        );
+      } else {
+        await bundle.write(rollupOption.output);
+      }
+    }),
+  );
 }