Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modifySorobanNetworkConfig #4605

Open
SirTyson opened this issue Jan 3, 2025 · 1 comment
Open

Fix modifySorobanNetworkConfig #4605

SirTyson opened this issue Jan 3, 2025 · 1 comment
Assignees
@ThomasBrady
Labels
bug

Comments

@SirTyson
Copy link
Contributor

SirTyson commented Jan 3, 2025

Currently, modifySorobanNetworkConfig manually adds NetworkConfig ledger entries to the BucketList. This has been causing bugs, as addBatch gets called twice on the same ledger. We should change modifySorobanNetworkConfig to actually externalize an upgrade to avoid issues with manual BucketList commits. This should look like upgradeSorobanNetworkConfig, but work on a single App reference instead of requiring a Simulation object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasBrady ThomasBrady

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThomasBrady @SirTyson and others