Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[1] More granular Kelp AppNames #488

Closed
nikhilsaraf opened this issue Aug 26, 2020 · 0 comments · Fixed by #517
Closed

[1] More granular Kelp AppNames #488

nikhilsaraf opened this issue Aug 26, 2020 · 0 comments · Fixed by #517
Assignees
@debnil
Labels
bug Something isn't working GUI issues related to the Kelp GUI
Milestone
v1.10.0

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Aug 26, 2020 •
edited
Loading

The goal of this task is to get better visibility into the source of requests coming in.

In trade.go (line), client AppName not started from the GUI says kelp, this should say kelp--cli--bot

In trade.go (line), client AppName started from the GUI says kelp-ui, this should say kelp--gui-desktop--bot

In file server_amd_64.go (line), client AppName for testnet and pubnet says kelp-ui, this should say:

  • If running with electron (options.noElectron not set): kelp--gui-desktop--admin-electron
  • If running without electron (options.noElectron is set): kelp--gui-desktop--admin-browser

When we run Kelp as a Service we can set a flag that uses "web" or "KaaS" instead of "desktop", or something similar.
@nikhilsaraf nikhilsaraf added bug Something isn't working GUI issues related to the Kelp GUI labels Aug 26, 2020
@nikhilsaraf nikhilsaraf added this to the v1.10.0 milestone Aug 26, 2020
@nikhilsaraf nikhilsaraf changed the title [0.5] Clarify Kelp GUI client AppNames [0.5] Mor egranular Kelp GUI client AppNames Aug 26, 2020
@nikhilsaraf nikhilsaraf changed the title [0.5] Mor egranular Kelp GUI client AppNames [0.5] More granular Kelp GUI client AppNames Aug 26, 2020
@nikhilsaraf nikhilsaraf changed the title [0.5] More granular Kelp GUI client AppNames [0.5] More granular Kelp AppNames Aug 26, 2020
@debnil debnil changed the title [0.5] More granular Kelp AppNames [1] More granular Kelp AppNames Sep 14, 2020
@debnil debnil mentioned this issue Sep 30, 2020
Merged
debnil added a commit that referenced this issue Oct 6, 2020
@debnil
Add more granular Kelp app names (closes #488)
1d69ab8 
PR #517
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@debnil debnil

Labels
bug Something isn't working GUI issues related to the Kelp GUI
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Add more granular Kelp app names (closes #488) stellar-deprecated/kelp
2 participants
@nikhilsaraf @debnil