-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nativeToScVal did not handle numbers correctly. #683
Comments
This is a JS issue. You went outside the bounds of the |
Allowing |
Yeah for ints larger than |
Furthermore, personally I tend not to support the use of |
Ah sure, that's right. If you know you have an integer, you should use |
Closed by #690! |
Describe the bug
The following code should output
false
, but we gottrue
,2 ** 127 - 1
was not converted correctly.What version are you on?
Check
yarn.lock
orpackage-lock.json
to find out precisely what version ofstellar-base
you're running.To Reproduce
Check the code above.
Expected behavior
Check the code above.
Additional context
i256, u128, and u256 also have this issue. I speculate that it is due to the incorrect handling of the sign bit?
The text was updated successfully, but these errors were encountered: