Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size-limit to CI to track package size #643

Closed
paulbellamy opened this issue Jul 12, 2023 · 1 comment
Closed

Add size-limit to CI to track package size #643

paulbellamy opened this issue Jul 12, 2023 · 1 comment

Comments

@paulbellamy
Copy link
Contributor

paulbellamy commented Jul 12, 2023 •
edited
Loading

Inspired by viem's usage of the size-limit js package in their CI pipeline to vet new PRs, we should add something similar to make sure our bundle size gets smaller over time.

Note: We should also add issues to do the same on other js libraries.
@Shaptic Shaptic mentioned this issue Jul 12, 2023
Merged
@Shaptic
Copy link
Contributor

Shaptic commented Jul 12, 2023

Done in #644! This does mean the compressed-size-action action requires secrets.GITHUB_TOKEN... Do we need a security review in that case?

@Shaptic Shaptic closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulbellamy @Shaptic