Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FUTURENET networkPassphrase #639

Closed
esteblock opened this issue Jul 3, 2023 · 2 comments
Closed

Add FUTURENET networkPassphrase #639

esteblock opened this issue Jul 3, 2023 · 2 comments

Comments

@esteblock
Copy link

Hello,
I am supporting the @soroban-react library, and for the @soroban-react/chains package I would like to do

import * as SorobanClient from "soroban-client";
export const futurenet : WalletChain = 
  {
    id: "public",
    name: "Futurenet",
    networkPassphrase: SorobanClient.Networks.FUTURENET,
  }

However SorobanClient.Networks.FUTURENET does not exist here

export enum Networks {

I think it would be good to add it as Futurenet is important for Soroban development

@Shaptic
Copy link
Contributor

Shaptic commented Jul 20, 2023

Oh wow you're right, though it's on the Networks object itself in the source code lol

@Shaptic
Copy link
Contributor

Shaptic commented Jul 20, 2023

Wait no, this is set in the soroban branch:

https://github.com/stellar/js-stellar-base/blob/soroban/types/index.d.ts#L241-L247

I opened #654 to fix the jsdocs, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants