Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: if seed is not present, calling Keypair.sign throws IllegalStateException. #662

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

overcat
Copy link
Member

@overcat overcat commented Nov 14, 2024

No description provided.

@overcat overcat enabled auto-merge (squash) November 14, 2024 09:07
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (54442eb) to head (5851dc6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #662   +/-   ##
=========================================
  Coverage     80.90%   80.90%           
  Complexity     1172     1172           
=========================================
  Files           203      203           
  Lines          4436     4436           
  Branches        370      370           
=========================================
  Hits           3589     3589           
  Misses          617      617           
  Partials        230      230           
Files with missing lines Coverage Δ
src/main/java/org/stellar/sdk/KeyPair.java 83.49% <100.00%> (ø)

@overcat overcat merged commit b9823f6 into master Nov 14, 2024
7 checks passed
@overcat overcat deleted the kp-sign-no-secret branch November 14, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant