Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Race condition in integration test #4992

Closed
2opremio opened this issue Jul 28, 2023 · 1 comment
Closed

services/horizon: Race condition in integration test #4992

2opremio opened this issue Jul 28, 2023 · 1 comment

Comments

@2opremio
Copy link
Contributor

Test TestIngestionFilteringAlwaysDefaultingToTrue/ingestion_filtering_flag_set_to_false if failing with a race condition. See https://github.com/stellar/go/actions/runs/5691674687/job/15428169554?pr=4990 from #4990

WARNING: DATA RACE
Write at 0x00c0003f8438 by goroutine 30721:
  runtime.racewrite()
      <autogenerated>:1 +0x24
  github.com/stellar/go/services/horizon/internal/ingest.(*system).Shutdown()
      /home/runner/work/go/go/services/horizon/internal/ingest/main.go:767 +0x150
  github.com/stellar/go/services/horizon/internal.(*App).waitForDone()
      /home/runner/work/go/go/services/horizon/internal/app.go:164 +0x164
  github.com/stellar/go/services/horizon/internal.(*App).Serve.func4()
      /home/runner/work/go/go/services/horizon/internal/app.go:133 +0x39

Previous read at 0x00c0003f8438 by goroutine 30718:
  runtime.raceread()
      <autogenerated>:1 +0x24
  github.com/stellar/go/services/horizon/internal/ingest.(*system).runStateMachine()
      /home/runner/work/go/go/services/horizon/internal/ingest/main.go:561 +0x74
  github.com/stellar/go/services/horizon/internal/ingest.(*system).Run()
      /home/runner/work/go/go/services/horizon/internal/ingest/main.go:466 +0x49
  github.com/stellar/go/services/horizon/internal.(*App).Serve.func1()
      /home/runner/work/go/go/services/horizon/internal/app.go:105 +0x5e

Goroutine 30721 (running) created at:
  github.com/stellar/go/services/horizon/internal.(*App).Serve()
      /home/runner/work/go/go/services/horizon/internal/app.go:132 +0x81d
  github.com/stellar/go/services/horizon/internal/test/integration.(*Test).StartHorizon.func4()
      /home/runner/work/go/go/services/horizon/internal/test/integration/integration.go:453 +0x55
@aditya1702
Copy link
Contributor

Closing since this a duplicate of #4987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants