Unstable order of claimable balance effects during liquidity pool revocation

[2opremio]

The Liquidity Pool revocation integration test is flaky due to the claimable balance effects not being ordered consistently in different executions.

See https://app.circleci.com/pipelines/github/stellar/go/9376/workflows/560678ef-ba51-40af-8d78-cec2dee83151 (e.g. https://app.circleci.com/pipelines/github/stellar/go/9376/workflows/560678ef-ba51-40af-8d78-cec2dee83151/jobs/53849 ).

This is (most probably) due to core's metadata not being ordered consistently (i.e. the relative order of the claimable balance changes of the liquidity pool assets should be stable).

We could consider this "feature" but I think core should always output the same order.

[jonjove]

There is no meaningful ordering on the meta within a single operation. We could pick an order, but sorting it into that order would make core slower. There is no reason to assume that every consumer expects the meta to have a specific order, so I don't really see a justification for making core slower.

[bartekn]

Fixed in #3943?

[2opremio]

Yep!