Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto reloading new versions of captive core relies on last modified timestamp which may be faulty #3882

Closed
tamirms opened this issue Sep 1, 2021 · 1 comment
Labels

Comments

@tamirms
Copy link
Contributor

tamirms commented Sep 1, 2021

In #3602 we implemented a feature in horizon which restarts captive core when a new version of captive core is detected on disk. The feature relied on last modified file timestamps to determine if the captive core binary was updated. However, when stellar core is installed via the debian packages the last modified timestamp of the binary is determined from the debian package changelog which is set to Nov 2018 for all versions of stellar core since 9.2.0-9.

Since the last modified timestamp is the same, horizon is not able to detect that captive core should be restarted. To make Horizon more robust to last modified timestamps we can instead use file hashes as the heuristic for determining if the captive core binary has been modified.

@tamirms tamirms added the bug label Sep 1, 2021
@tamirms
Copy link
Contributor Author

tamirms commented Jan 5, 2022

Fixed in #4050

@tamirms tamirms closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant