Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testnet/pubnet sync, catchup (BoundedRange) and reingest integration tests #3248

Closed
bartekn opened this issue Nov 24, 2020 · 4 comments · Fixed by #3267
Closed

Add testnet/pubnet sync, catchup (BoundedRange) and reingest integration tests #3248

bartekn opened this issue Nov 24, 2020 · 4 comments · Fixed by #3267

Comments

@bartekn
Copy link
Contributor

bartekn commented Nov 24, 2020

Add integration tests that sync with the network: build state and ingest a few ledgers. This will help ensure that Horizon is able to sync and catch bugs like #3231 before release testing.

@bartekn bartekn changed the title Add testnet/pubnet sync integration tests Add testnet/pubnet sync and catchup (BoundedRange) integration tests Dec 1, 2020
@bartekn bartekn changed the title Add testnet/pubnet sync and catchup (BoundedRange) integration tests Add testnet/pubnet sync, catchup (BoundedRange) and reingest integration tests Dec 3, 2020
@2opremio 2opremio self-assigned this Dec 3, 2020
@bartekn
Copy link
Contributor Author

bartekn commented Dec 7, 2020

To clarify, I think we should test 3 things:

  1. starting from scratch to check if horizon can build state without a problems + a few ledgers,
  2. starting from existing DB (start -> resume transition in FSM scenario). this would catch ingest/ledgerbackend: Fix off-by-one in CaptiveStellarCore.runFromParams #3231,
  3. horizon db reingest so we are sure that reingesting works (I believe it doesn’t in the latest version because of ingest/ledgerbackend: Remove returning error on Stellar-Core process exit during catchup #3260).

@bartekn
Copy link
Contributor Author

bartekn commented Dec 7, 2020

@2opremio @tamirms you asked why we should do testnet/pubnet tests and I answered that I was probably wrong and standalone should work too. That's true but what is the status of captive core tests in standalone? I'm looking at #3267 and realized that it wouldn't catch #3231 or #3260 because both issues were connected to captive core.

@2opremio
Copy link
Contributor

2opremio commented Dec 7, 2020

Note that as soon as the integration tests can be run with captive core (which is almost there, I think) the tests at #3267 will be run with captive core too.

@bartekn
Copy link
Contributor Author

bartekn commented Dec 7, 2020

OK! I just wanted to confirm we'll be able to have them before beta. If not, it would be great to have testnet/pubnet tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants