Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --duration param to verify-range command #2112

Closed
bartekn opened this issue Jan 13, 2020 · 2 comments
Closed

Add --duration param to verify-range command #2112

bartekn opened this issue Jan 13, 2020 · 2 comments
Labels

Comments

@bartekn
Copy link
Contributor

bartekn commented Jan 13, 2020

When testing old ledgers using verify-range (#1848) we should also ensure that speed of ingestion is fast enough. To achieve this we can add --duration param to verify-range that specifies time limit in ms in which ledger should be ingested. If it exceeds the limit, verify-range should print an error and return non-zero exit code.

When it comes to implementation we should probably add timer to pre, post hooks (post hook after commiting to DB).

@bartekn bartekn added this to the Horizon 0.25.0 milestone Jan 13, 2020
@bartekn
Copy link
Contributor Author

bartekn commented Jan 19, 2020

Let's skip it for now. I was able to find the slow ledgers using CloudWatch log query. For future reference:

filter @message like /duration=/
| filter @message like /Finished processing ledger/
| parse 'duration=* ledger=* ' as duration, ledger
| filter duration > 5
| sort duration desc

EDIT: query post ingestion refactoring:

filter @message like /duration=/
| filter @message like /Processed ledger/
| parse 'duration=* graph=* ledger=* pid=* sequence=* ' as duration, graph, ledger, pid, sequence
| filter duration > 5
| sort duration desc

@bartekn bartekn removed this from the Horizon 0.25.0 milestone Jan 19, 2020
@bartekn
Copy link
Contributor Author

bartekn commented Feb 3, 2020

Closing, it's easier to check this by analysing log output.

@bartekn bartekn closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant