-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember help generate #952
ember help generate #952
Conversation
jgwhite
commented
Jun 9, 2014
Definitely 👍. I would love to see the same output from |
RebAse |
So why add list. When help is already present? |
@stefanpenner seemed like it would take a little refactoring to get it into help, and that this would be the most expedient why to provide these docs. Aiming to integrate with help eventually. |
i would prefer to hold of an interim feature like this, if it will be entirely replaced with help in the future. I fear adding/removing flags is a great way to confuse people. |
@stefanpenner cool. I'll push ahead integrating it with help. |
cc @njj023 |
@stefanpenner @rjackson this is ready for another pass. Refactored Not tied to the naming of those methods, though it seems appropriate they match up with the |
Looks good. I like the name change (makes it much clearer what each thing does). 👍 |
This got me thinking: should a blueprint also have the ability to print information? I'm thinking that a blueprint named I do not think that this proposal should block this PR though. I think this is absolutely a step in the right direction, and I'd like this available in the next release. Then as we have time, we can add the blueprint level printouts. |
@rjackson been thinking exactly the same. $ ember help generate
ember-cli:
model <attr:type...>
route <type:(resource|route)>
... |
Yes, exactly! But I think that could be a second PR building on this one (so as not to hold this up from the next release), unless of course you disagree and want to tackle it here... |
Let’s add it in a second PR. |
Sadly, due to CHANGELOG shenanigans this will need to be rebased. |
Rebased. |
assert.include(output, ' controller'); | ||
assert.include(output, ' helper'); | ||
assert.include(output, ' initializer'); | ||
assert.include(output, ' integration'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is not happy, and I'm pretty sure it's because this needs to be updated (due to the rename from integration to acceptance).
Refactor help API around `printBasicHelp` and `printDetailedHelp`. `ember help` uses `printBasicHelp` `ember help <command-name>` prints basic and detailed help. Implement `printDetailedHelp` in the generate command to list out available blueprints, grouped by package.
Whoops! Forgot about that. Should be good now. |
this is awesome!! |