Disable slow tree log within ember test --server.
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `testem` UI does not always repaint the full screen, which means that in some scenarios the slow tree log bleeds through and there is no testem command to for repaint the full screen (that I know of at least).
| @@ -39,7 +39,7 @@ module.exports = Command.extend({ | |||
| var TestServerTask = this.tasks.TestServer; | |||
| var testServer = new TestServerTask(options); | |||
|
|
|||
| testOptions.watcher = new Watcher(options); | |||
| testOptions.watcher = new Watcher(assign(options, {verbose: false})); | |||
There was a problem hiding this comment.
is this a better case for lodash defaults ?
There was a problem hiding this comment.
I can change if you'd prefer, but it seems that assign is what we want here. My understanding of the difference is that with assign and defaults:
assign-- thesource({verbose:false}in this case) will "win" (even ifoptionsalready has averboseproperty).defaults-- thesource({{verbose:false}in this case) will lose ifoptionsalready has averboseproperty.
It is a moot point in our case since we are creating options directly above and we know it cannot have a verbose prop in it, but if it were possible for options to have verbose already set I still think assign is the right call here since we always want verbose to be false when running under testem (the testem UI completely covers any logging anyways).
stefanpenner
added a commit
that referenced
this pull request
Jun 1, 2014
Disable slow tree log within `ember test --server`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testemUI does not always repaint the full screen, which means that in some scenarios the slow tree log bleeds through and there is no testem command to for repaint the full screen (that I know of at least).Fixes #867.