-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose server, server baseURL stuff, project.require() #683
Conversation
'use strict'; | ||
|
||
module.exports = function(baseURL) { | ||
if (!baseURL) { return; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function should be very easy to test, as it has some algorithmic complexity please add some tests for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created one.
i made some comments, but think this is a great addition. |
Expose server, server baseURL stuff, project.require()
Just tried this out and I noticed that Thoughts? |
The body parser was previously part of express. If you tend to include it anyway we might as well ship with it. Mind providing a PR? |
Info about changes in changelog.
@stefanpenner @rjackson Please review this. I'd like to merge it in the next view hours. Rebasing is a pain ;)