Add JSHinting. #482
Merged
Add JSHinting. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently blowing up pretty hard because it only seems to be taking the root JSHint file into consideration, which doesn't ignore the testing specific terms. |
|
@WMeldon can you open an issue |
|
@stefanpenner - I've talked to @WMeldon in IRC, and he is going to open an issue in the broccoli-jshint repo. I'll tackle it tonight... |
|
lets track on issue here too, this should block the 0.0.24 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the broccoli-jshint package to provide JSHinting support. broccoli-jshint generates console warning messages as well as QUnit tests so that JSHint errors fail the build.
Screenshot showing things passing on a newly generated application:
Screenshot showing a few errors: