Add preBuild hook for addons (Resolves #2410) #2411
Conversation
brittanydionigi
force-pushed
the
feature/addon_prebuild_hook
branch
from
c93d636 to
b713493
Compare
| buildResults = 'build results'; | ||
| }); | ||
|
|
||
| it('allows addons to add promises prebuild', function() { |
brittanydionigi
force-pushed
the
feature/addon_prebuild_hook
branch
from
72d9931 to
b1e8651
Compare
|
Not sure why this is failing at AppVeyor, tests pass locally for me. Seems there are a couple PRs with similar AppVeyor issues, but not sure what the common thread could be. |
AppVeyor has not yet been green. We are slowly attempting to fix AppVeyor issues, but we generally use Travis status for mergability at this point. |
|
Oh good to know, thanks! |
|
👍 from me |
|
@stefanpenner will need to confirm |
| .then(this.processBuildResult.bind(this)) | ||
| .then(this.addonsPostBuild.bind(this)); | ||
| .then(this.processAddonBuildSteps.bind(this, 'postBuild')); |
There was a problem hiding this comment.
truthfully this is postBuild if build was successful, should we also have a buildFailed or should these actually occur in finally
There was a problem hiding this comment.
I think postBuild should always be happy path (non failure) because the addons expect the directory to be provided, but definitely agree that we should add a buildFailed hook in a catch.
I also, think that this PR adds the proper foundation, and we can add buildFailed in a subsequent PR.
|
awesome thank you. We can add error instrumentation later (if we need). |
Add preBuild hook for addons (Resolves #2410)
This creates a preBuild hook for add-ons, based on the work that was done for creating a postBuild hook. #1215
As noted in #2410, an example use case for this feature might be when there are file checks or manipulations you need to make prior to the build process.