-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split bower_components into it's own directory #1436
Conversation
This will need doc updates and a breaking changelog entry but I think it's a good idea |
Should we remove |
👍 +1 for removing |
I'm generally 👍, but I'd like to wait until we ship 0.0.40 before merging, then we can have some time to track any issues down while working from master. |
@rwjblue agreed, lets slate it for after 0.0.40 |
sounds good |
refs also #1020 |
@jakecraige can you rebase? @stefanpenner anything else holding this up now that |
@bcardarella this a rebase + changelog entry + doc updates |
@jakecraige - Can you rebase and add a changelog entry? We will also need a gh-pages PR (to be merged when the release is published). |
@rjackson I should be able to tomorrow morning. Been moving all weekend and On Sunday, August 3, 2014, Robert Jackson notifications@github.com wrote:
Thanks, Jake Craige |
@jakecraige best of luck moving i hope it went well :) |
@stefanpenner Today is put together the new IKEA furniture day! @rwjblue Rebased and changelog updated. gh-pages PR still merges cleanly so I think that should be fine still |
@@ -389,7 +389,7 @@ EmberApp.prototype.javascript = memoize(function() { | |||
var legacyFilesToAppend = this.legacyFilesToAppend; | |||
|
|||
if (this.tests) { | |||
this.import('vendor/ember-qunit/dist/named-amd/main.js', { | |||
this.import('bower_components/ember-qunit/dist/named-amd/main.js', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are merging bower_components
and vendor
into the vendor
tree (in our constructor), then moving the vendor
tree into a vendor/
destDir (in _processedVendorTree). So at this point shouldn't this still be vendor
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwjblue It's kind of personal preference. Either one actually works fine. Though semantically I figured bower_components makes more sense as that's the actual location of the file on disk.
Split bower_components into it's own directory
refs #757